| Summary: | Update preview in CSV import dialog when the language is changed | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Heiko Tietze <heiko.tietze> |
| Component: | Calc | Assignee: | Not Assigned <libreoffice-bugs> |
| Status: | NEW --- | ||
| Severity: | enhancement | CC: | andreas.heinisch, b7.10110111, vsfoote |
| Priority: | medium | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=39829 | ||
| Whiteboard: | |||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 109239 | ||
|
Description
Heiko Tietze
2018-06-21 08:49:08 UTC
Sounds good -> NEW The csv import relies on the separators shown in the import dialog. So, if you change the language, the old separators are still used. A solution could be that on changing the language, the separators will be updated according to the decimal separator, but I don't know if that causes side effects for the user: The dialog shows Tab, Comma, Semicolon, etc. The user changes the language from English to German. Now the semicolon should not be used as a separator, because it may interfer with the thousand separator, and the preview is updated accordingly. This can be achieved also by clicking on the separator checkbox. Opinions? Sry, a typo: Now the comma should not be used as a separator ... I think we don't have the logic yet to check/uncheck the delimiters depending on the chosen language. This ticket was about 1,2;3,4 (German) vs. 1.2;3.4 (English) and the wish to set the language automatically. Switching to English could indeed also uncheck the comma to read 1,234.56;7,890.12 as numbers. However, in contrast to the first request 1.2 and 1,2 being a proper number eventually, the wrong delimiter is easy to spot in the preview. What's your take, Andreas, after unassigning yourself? Better not touch it at all and resolve WF? Hm, we could set the separators accordingly when changing the language (un- or checking the comma separator), and checking for the correct language for the given numbers, which can be tricky. I was unchecking myself, since I don't know exactly how the dialog should react to different scenarios: - Handle the correct separator when changing the language - Try to parse thr correct separator and change the language accordingly, but this could be tricky: 123,345 could be German or English or even two cols 123 , 345 depending on the separator. |